[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Fix pygrub with "many" kernels


  • To: Jeremy Katz <katzj@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Thu, 05 Oct 2006 16:12:35 +0100
  • Delivery-date: Thu, 05 Oct 2006 08:13:06 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcbokK/b7oFyzFSDEduatwAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH] Fix pygrub with "many" kernels



On 4/10/06 22:57, "Jeremy Katz" <katzj@xxxxxxxxxx> wrote:

> Attached fixes running pygrub with many kernels to do proper scrolling
> 
> Signed-off-by: Jeremy Katz <katzj@xxxxxxxxxx>

+        if self.selected_image > self.start_image + maxy:
+            self.start_image = self.selected_image
+        if self.selected_image < self.start_image:
+            self.start_image = self.selected_image

Shouldn't the second line above be:
     self.start_image = self.selected_image - maxy

So that the selected image is the one at the bottom of the displayed
subsection of the list?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.