[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [IMPORTANT BUGFIX][ACM][XM] FIX essential security check in block-attach / indentation problem introduced in change set changeset 11572

This patch fixes an indentation error in main.py. The effect of this bug is that block-attach does not check labels if the ACM is active. This bug slipped in with change set 11572_:_ ad22c711ccb7 <http://xenbits.xensource.com/xen-unstable.hg?cs=ad22c711ccb7>.

This patch is essential and should get into 3.0.3. I tested the patch with security off and on.

P.S. We are currently enhancing xm-test to include security tests so that we can detect simple things like this faster.

Signed-off by: Reiner Sailer <sailer@xxxxxxxxxx>

 tools/python/xen/xm/main.py |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: xen-unstable.hg-shype/tools/python/xen/xm/main.py
--- xen-unstable.hg-shype.orig/tools/python/xen/xm/main.py
+++ xen-unstable.hg-shype/tools/python/xen/xm/main.py
@@ -1222,7 +1222,8 @@ def parse_block_configuration(args):
         label = security.get_security_printlabel(dominfo)
         label = None
-        security.res_security_check(args[1], label)
+    security.res_security_check(args[1], label)
     return (dom, vbd)

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.