[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 11/11] build: Don't assume that mkbuildtree is executable



On Thu, Apr 13, 2006 at 11:21:55AM +0100, Keir Fraser wrote:
> 
> On 13 Apr 2006, at 03:22, Horms wrote:
> 
> >>>Understood, if they are indeed all using /bin/bash at the moment.  It
> >>>seems as well to just specify bash. It can be made more flexible if 
> >>>the
> >>>need arises. Here is an updated patch.
> >>
> >>Let's not risk any regressions: it should be /bin/bash, and apart from
> >>the configurability argument it's also cleaner imo to define a wrapper
> >>variable for /bin/bash in Config.mk.
> >
> >Understood
> 
> That turns out quite ugly doesn't it... maybe I prefer the previous 
> patch (just use bash) after all. I guess bash will always be findable 
> via PATH anyway, and we *know* we need bash, so selecting a different 
> shell would not be a good idea.

I'm comfortable either way, so please use whichever you prefer.

-- 
Horms

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.