[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Missing CDROM media



Ross Maxfield wrote:
If the 'cdrom=' option is specified in the definition file but media is not 
found in the CD drive then main() in vl.c exits and the guest appears to hang.  
This patch modifies vl.c slightly to check for the presents of media.  If the 
cdrom cannot be opened then the cd entry is removed from hd_filename[] and 
bs_table[] allowing the guest to continue initializing. If the guest requires 
the CD media then the guest should report, gracefully or otherwise, that it's 
missing.

This is desired behavior.

The cdrom is always attached to the guest. The cdrom option doesn't necessary attach a cdrom but rather attaches the media to the already existing cdrom. If you wish to later change the media, use the "change" option in the monitor.

Moving away from QEmu semantics is only going to make merging later more difficult. You could perhaps add a check to Xend that remove the cdrom option if media wasn't present. Then can expose the user interface we want without moving further away from QEmu.

Regards,

Anthony Liguori

I would like to see this patch applied to 3.0.2-testing as well.

Thanks,
Ross

------------------------------------------------------------------------

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.