WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xense-devel

Re: [Xen-devel][Xense-devel][PATCH][XSM][1/4] Xen Security Modules Patch

To: Alex Williamson <alex.williamson@xxxxxx>
Subject: Re: [Xen-devel][Xense-devel][PATCH][XSM][1/4] Xen Security Modules Patch
From: "George S. Coker, II" <gscoker@xxxxxxxxxxxxxx>
Date: Thu, 08 Mar 2007 11:16:48 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xense-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 08 Mar 2007 08:15:28 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1173369547.5941.212.camel@bling>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1173367723.11144.29.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <1173369547.5941.212.camel@bling>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2007-03-08 at 08:59 -0700, Alex Williamson wrote:
> On Thu, 2007-03-08 at 10:28 -0500, George S. Coker, II wrote:
> > +    /*
> > +     * Try all modules and see whichever could be the binary policy.
> > +     * Adjust the initrdidx if module[1] is the binary policy.
> > +     */
> > +    for (i = mbi->mods_count-1; i >= 1; i--) {
> > +#if defined(__i386__)
> > +        _policy_start = (u32 *)(initial_images_start + 
> > (mod[i].mod_start-mod[0].mod_start));
> > +#elif defined(__x86_64__)
> > +        _policy_start = __va(initial_images_start + 
> > (mod[i].mod_start-mod[0].mod_start));
> > +#else
> > +#error Architecture unsupported by XSM
> > +#endif
> 
>    This is unacceptable, please make it fail gracefully on non-x86.

Indeed, it looks like this logic is outdated.  This was based on some
older code from ACM.  The attached patch addresses this issue.


> Thanks,
> 
>       Alex
>  
-- 
George S. Coker, II <gscoker@xxxxxxxxxxxxxx> 443-479-6944

Attachment: xsm-policy-init-030807.diff
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel