[Xen-tools] Re: [PATCH 1/3] Recover transaction on restart, give transactions IDs

[Rusty Russell <rusty@xxxxxxxxxxxxxxx>]

On Mon, 2005-09-26 at 19:57 +0100, Christian Limpach wrote:
> Rusty,
> 
> I don't agree with this approach since it relies on the fact that
> we won't suspend/resume within a transaction.

If we suspend/resume over transactions, this mechanism will not work by
itself, it will still work for local tools over xenstored restart.

But transactions are a privileged operations (either in-kernel
or /proc/xen/xenbus), and are short, so I don't see it as being an
issue.  If it becomes an issue, I'd much rather do transaction migration
than present a horrible API to xenstore users for such a corner case.

As predicted, the change to have xs_transaction_end return EAGAIN made
the kernel code uglier and caused bugs (thanks Keir for the fixes so
far).  Returning EAGAIN from arbitrary operations is going to make it
worse.  I'm convinced we don't want to go there.

Cheers,
Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman


_______________________________________________
Xen-tools mailing list
Xen-tools@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-tools