This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Make xend reject duplicates and rename zombies

To: Anthony Liguori <aliguori@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Make xend reject duplicates and rename zombies
From: Dan Smith <danms@xxxxxxxxxx>
Date: Thu, 15 Sep 2005 12:16:33 -0700
Cc: Xen Tools Developers <xen-tools@xxxxxxxxxxxxxxxxxxx>, Xen Developers <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 15 Sep 2005 19:16:10 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4329C366.2070006@xxxxxxxxxx> (Anthony Liguori's message of "Thu, 15 Sep 2005 13:54:30 -0500")
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <87br2uz5yj.fsf@xxxxxxxxxx> <4329C366.2070006@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3 (gnu/linux)
AL> This patch renames the domain name which prevents a name class but
AL> does not solve the general problem.

I agree.  This is why in my original patch, I simply had the create
routine reject attempts to create domains with duplicate names.

Further, I will point out that what I meant by my comment attached to
this patch was not that it solved the general problem, but that it
seemed to make the problem not get in the way of some of my existing
tests :)

AL> I think the right solution is to make xm destroy not return until
AL> the domain has actually gone away and add a flag to xm destroy to
AL> return immediately if that behavior is ever desired.

Yep, I think that's a much better solution.  So, I think my original
patch should still be applied: xend should do its own checking for
duplicates, so that we don't rely on whatever tool is asking us to do

Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms@xxxxxxxxxx

Xen-devel mailing list