WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

Re: [XenPPC] fast_resume instead of full_resume after hdec_out

To: hs8848.jang@xxxxxxxxxxx
Subject: Re: [XenPPC] fast_resume instead of full_resume after hdec_out
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Wed, 12 Sep 2007 15:31:25 -0500
Cc: Seung-Mo Cho <seungm.cho@xxxxxxxxxxx>, "xen-ppc-devel@xxxxxxxxxxxxxxxxxxx" <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 12 Sep 2007 13:31:56 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <28511614.253831189484572536.JavaMail.weblogic@ep_ml22>
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <28511614.253831189484572536.JavaMail.weblogic@ep_ml22>
Reply-to: Hollis Blanchard <hollisb@xxxxxxxxxx>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx
Sounds reasonable to me.

When I get a chance I'll try it out; I need to do a little work to track
upstream Xen changes anyways. I don't think I'll have time in the next
two weeks though (just FYI)...

On Tue, 2007-09-11 at 04:22 +0000, HYEONSEUNG JANG wrote:
> In handling hdec exception, non-volatile registers are saved because
> context_switch() may be called in the do_softirq(). The fact that we
> reach to 'hdec_out' means that there has been no context_switch()
> called. But currently 'fast_resume' is called after 'hdec_out'
> 
> I think there seems to be no reason to restore non-volatiles at this
> point. Becasue MSR_EE is alwyas 0, 'fast_resume' will be enough like the
> following. It seems to work well in our HW. Please give me comments or
> something.
> 
> - Hyeonseung Jang.
> 
> 
> 
> diff -r 9071521d4864 xen/arch/powerpc/powerpc64/exceptions.S
> --- a/xen/arch/powerpc/powerpc64/exceptions.S Fri Sep 07 11:39:10 2007 +0100
> +++ b/xen/arch/powerpc/powerpc64/exceptions.S Tue Sep 11 11:38:25 2007 +0900
> @@ -514,6 +514,7 @@ hdec_out:
>  hdec_out:
>      addi r1, r1, STACK_FRAME_OVERHEAD   /* restore stack to cpu_user_regs */
>      LOAD_GPRS r14, r15, r1              /* we clobbered r14/r15 in the loop 
> */
> +    b fast_resume
>  
>  /* r1 points to the to-be-restored cpu_user_regs. These could be 
> mid-hypervisor
>   * stack (returning into elsewhere in Xen) or at the top of the stack
> 
> 
> 
> _______________________________________________
> Xen-ppc-devel mailing list
> Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-ppc-devel
-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel

<Prev in Thread] Current Thread [Next in Thread>