Re: [Xen-devel] [PATCH 2/3] xencomm take 4: xen side multiple page support

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

On Tue, Aug 28, 2007 at 03:45:56PM +0100, Keir Fraser wrote:
> On 28/8/07 07:17, "Isaku Yamahata" <yamahata@xxxxxxxxxxxxx> wrote:
> 
> > +static int
> > +xencomm_ctxt_next(struct xencomm_ctxt *ctxt, int i)
> > +{
> > +    BUG_ON(i >= ctxt->nr_addrs);
> > +    /* in i == 0 case, we already calculated in xecomm_addr_init() */
> > +    if ( i != 0 )
> > +        ctxt->address++;
> 
> This function may deserve a comment -- what is it for? The 'i == 0' comment
> is confusing, and appears to refer to a function that doesn't exist (I
> couldn't find any function with suffix _addr_init()).
> 
> These patches are all in the staging tree now, so provide delta patches to
> apply on top.

I attached the patch to add the comment. I hope that the comment clarify.

-- 
yamahata

15783_d4283f2a12f7_comment_xencomm_ctxt_next.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel