WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

Re: [Xen-devel] [PATCH 2/3] xencomm take 4: xen side multiple page suppo

To: Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2/3] xencomm take 4: xen side multiple page support
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Wed, 29 Aug 2007 11:43:24 +0900
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 28 Aug 2007 19:43:53 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C2F9F3B4.14F56%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070828061736.GA7841%yamahata@xxxxxxxxxxxxx> <C2F9F3B4.14F56%keir@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Tue, Aug 28, 2007 at 03:45:56PM +0100, Keir Fraser wrote:
> On 28/8/07 07:17, "Isaku Yamahata" <yamahata@xxxxxxxxxxxxx> wrote:
> 
> > +static int
> > +xencomm_ctxt_next(struct xencomm_ctxt *ctxt, int i)
> > +{
> > +    BUG_ON(i >= ctxt->nr_addrs);
> > +    /* in i == 0 case, we already calculated in xecomm_addr_init() */
> > +    if ( i != 0 )
> > +        ctxt->address++;
> 
> This function may deserve a comment -- what is it for? The 'i == 0' comment
> is confusing, and appears to refer to a function that doesn't exist (I
> couldn't find any function with suffix _addr_init()).
> 
> These patches are all in the staging tree now, so provide delta patches to
> apply on top.

I attached the patch to add the comment. I hope that the comment clarify.

-- 
yamahata

Attachment: 15783_d4283f2a12f7_comment_xencomm_ctxt_next.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>