WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

Re: [Xen-devel] Re: [XenPPC] [PATCH 2/7] xencomm take 3: xen side prepar

To: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [XenPPC] [PATCH 2/7] xencomm take 3: xen side preparetion for consolidation.
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Wed, 15 Aug 2007 08:41:54 -0500
Cc: xen-ppc-devel@xxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 15 Aug 2007 06:42:19 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070815034605.GA32511%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <20070814095023.GA27679%yamahata@xxxxxxxxxxxxx> <1187102880.30063.4.camel@basalt> <20070815034605.GA32511%yamahata@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2007-08-15 at 12:46 +0900, Isaku Yamahata wrote:
> On Tue, Aug 14, 2007 at 09:48:00AM -0500, Hollis Blanchard wrote:
> 
> > However, there are a few places below where you call memcpy() without
> > checking the result of xencomm_maddr_to_vaddr(). Actually, I see the
> > same issue in the original code in a few places... We should be very
> > very careful here, since a guest passing a bad paddr could result in Xen
> > overwriting 0x0.
> 
> Thank you for comments. The next patch (3/7) addresses those issues.
> i.e. checking guest supplied values, avoiding races.
> I intentionally kept this patch(2/7) as small as possible leaving them
> to the next patch (3/7).

Ah, great.

> Since we can work around the populate physmap issue,
> it's ok for me to drop multi page support.
> But we need the next patch or something similar.
> If you dislike the implementation, I'm willing to refine it.
> Please suggest.

Patch 3 looks fine to me. I would like to give it a boot test first
though, and unfortunately I won't be able to do that today. I'll add my
signed-off line tomorrow after I've tried it.

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>