WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

Re: [XenPPC] noHV patches as of 10/05/2006

To: Mark F Mergen <mergen@xxxxxxxxxx>
Subject: Re: [XenPPC] noHV patches as of 10/05/2006
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Thu, 05 Oct 2006 16:19:34 -0500
Cc: xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 05 Oct 2006 14:19:53 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <OF63BD336C.DB66B8EC-ON852571FE.002B79AB-852571FE.002CD544@xxxxxxxxxx>
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <OF63BD336C.DB66B8EC-ON852571FE.002B79AB-852571FE.002CD544@xxxxxxxxxx>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi Mark, just some quick comments...

On Thu, 2006-10-05 at 04:09 -0400, Mark F Mergen wrote:
> 
> -void do_dec(struct cpu_user_regs *regs)
> +void do_dec(struct cpu_user_regs *regs, struct vcpu* vcpu) 
...
> -void program_exception(struct cpu_user_regs *regs, unsigned long
> cookie)
> +void program_exception(struct cpu_user_regs *regs,
> +                      unsigned long cookie, struct vcpu* vcpu)
...
> -void deliver_ee(struct cpu_user_regs *regs)
> +void deliver_ee(struct cpu_user_regs *regs, struct vcpu* vcpu)

I think you should simply use 'current' inside these exception handlers.

> -    if (regs->msr & MSR_PR) {
> +    if ((regs->msr & MSR_PR) && (current->arch.vmsr & MSR_PR)) {

Could you define a "in_usermode(regs)" accessor and use that instead?

> @@ -362,6 +366,9 @@ static void __init __start_xen(multiboot
>      dom0->vcpu[0]->cpu_affinity = cpumask_of_cpu(0);
>  
>      set_bit(_DOMF_privileged, &dom0->domain_flags);
> +    if (opt_nohv)
> +        set_bit(_DOMF_prob, &dom0->domain_flags);
> +
>      /* post-create hooks sets security label */
>      acm_post_domain0_create(dom0->domain_id);

Does this mean you only have dom0 working, or domU as well?

I'm not going to go through the exception handler changes right now...

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel

<Prev in Thread] Current Thread [Next in Thread>