WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

Re: [PATCH] Re: [XenPPC] XenPPC: redundancy definition of __trap_to_gdb

I think hollis nailed correctly, does it work for everyone?
# HG changeset patch
# User Hollis Blanchard <hollisb@xxxxxxxxxx>
# Node ID c3312bbd598a50b3c48955a8f4c9dba6330fc7d8
# Parent  d1f6d0f820d890ac6075f47ad1ba6e38012167b4
[POWERPC][XEN] Move gmfn_to_mfn() from page.h to mm.h to avoid recursive header dependencies.
Signed-off-by: Hollis Blanchard <hollisb@xxxxxxxxxx>

-JX
On Oct 4, 2006, at 12:50 AM, Tony Breeds wrote:

On Tue, Oct 03, 2006 at 02:56:14PM -0400, Amos Waterland wrote:

I'm not positive of this, but I'm pretty sure that this is caused by
improper dependency checking.  I suspect that you changed from
debug=n to debug=y and got this. I'd suggest doing a `make clean' and
trying again without your patch.

I came accross the same probelm with a clean build. The patch below fixes it
for me.

Reorder includes to help the complier and avoid redundat definition of __trap_to_gdb.

Signed-off-by: Tony Breeds <tony@xxxxxxxxxxxxxxxxxx>

---
 xen/arch/powerpc/gdbstub.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff -r d1374d869111 xen/arch/powerpc/gdbstub.c
--- a/xen/arch/powerpc/gdbstub.c        Wed Oct 04 13:44:07 2006 +1000
+++ b/xen/arch/powerpc/gdbstub.c        Wed Oct 04 14:46:07 2006 +1000
@@ -20,12 +20,12 @@

 #include <xen/types.h>
 #include <xen/lib.h>
-#include <xen/gdbstub.h>
 #include <public/xen.h>
 #include <asm/msr.h>
 #include <asm/bitops.h>
 #include <asm/cache.h>
 #include <asm/debugger.h>
+#include <xen/gdbstub.h>
 #include <asm/processor.h>

 asm(".globl trap_instruction\n"

Yours Tony

linux.conf.au http://linux.conf.au/ || http:// lca2007.linux.org.au/
   Jan 15-20 2007      The Australian Linux Technical Conference!


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel