This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [XenPPC] [PATCH] Fix a couple of typos

To: Tony Breeds <tony@xxxxxxxxxxxxxxxxxx>
Subject: Re: [XenPPC] [PATCH] Fix a couple of typos
From: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
Date: Tue, 29 Aug 2006 09:28:47 -0400
Cc: XenPPC-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 29 Aug 2006 06:29:02 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060829064947.GS27551@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060829064947.GS27551@xxxxxxxxxxxxxxxxxx>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx

On Aug 29, 2006, at 2:49 AM, Tony Breeds wrote:

From: Tony Breeds <tony@xxxxxxxxxxxxxxxxxx>

While getting xend/domU up and runngin today I noticed what
look like a couple of typos.

AFAICT do_dom0_op will return 0 or -1, so the failure test in
tools/libxc/powerpc64/xc_memory.c has the wrong operator.

Also in xen/arch/powerpc/shadow.c:shadow_set_allocation() rc is unused
and thus returning stack garbage.

Good catch!


Xen-ppc-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>