This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [XenPPC] [xenppc-unstable] [POWERPC][XEN] Allocate more memory than

To: Hollis Blanchard <hollisb@xxxxxxxxxx>
Subject: Re: [XenPPC] [xenppc-unstable] [POWERPC][XEN] Allocate more memory than RMA for Dom0
From: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
Date: Mon, 28 Aug 2006 14:25:16 -0400
Cc: xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 28 Aug 2006 11:25:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1156780057.28490.26.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E1GHR7P-0000j0-Tp@xxxxxxxxxxxxxxxxxxxxx> <1156780057.28490.26.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx

On Aug 28, 2006, at 11:47 AM, Hollis Blanchard wrote:

On Sun, 2006-08-27 at 20:20 +0000, Xen patchbot-xenppc-unstable wrote:

+    /* make sure we are at least as big as the RMA */
+    if (dom0_nrpages < rma_nrpages)
+        dom0_nrpages = rma_nrpages;
+    else
+ dom0_nrpages = allocate_extents(d, dom0_nrpages, rma_nrpages);

     d->tot_pages = dom0_nrpages;
     ASSERT(d->tot_pages > 0);

Note that dom0_nrpages here doesn't do anything other than confuse the
memory accounting (though we don't try to destroy dom0, so it doesn't
matter too much ATM).

good catch.. I'll simplify

In particular, we're assigning d->tot_pages without actually doing any
heap allocation.
we should end up reassigning the same value redundantly.

Xen-ppc-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>