This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [XenPPC] PATCH: Inline assembler for clear_page() and copy_page()

On Mon, 2006-08-28 at 13:20 -0400, Jimi Xenidis wrote:
> On Aug 28, 2006, at 1:10 PM, Hollis Blanchard wrote:
> > Right. As long as we're changing this code, let's include copy_page().
> >
> > ... which brings us back to the original patch a) removing the call to
> > mambo_memcpy(), and b) missing dcbtst.
> I think we should use the linux copy4kpage() strategy for this.. no  
> sense reinventing the wheel.

I'm fine with copying whatever Linux does here. At least they've
unrolled it. :) It's just too bad it's 100% comment-free. :(

> We should also consider sending a linux patch upstream that has this  
> function use dcbz or find out why they did not.


Hollis Blanchard
IBM Linux Technology Center

Xen-ppc-devel mailing list