WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

Re: [XenPPC] [xenppc-unstable] [TOOLS] avoid shadow ops for POWERPC

To: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
Subject: Re: [XenPPC] [xenppc-unstable] [TOOLS] avoid shadow ops for POWERPC
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Mon, 21 Aug 2006 15:00:34 -0500
Cc: xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 21 Aug 2006 13:00:04 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <DC037C5A-F15D-4E58-84C6-3726B966767C@xxxxxxxxxxxxxx>
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <E1GEqqH-0007t0-VD@xxxxxxxxxxxxxxxxxxxxx> <DC037C5A-F15D-4E58-84C6-3726B966767C@xxxxxxxxxxxxxx>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Sun, 2006-08-20 at 13:28 -0400, Jimi Xenidis wrote:
> Hollis, I'm sure you have a better way to do this in the TCL.
> I'll be adding some shadow ops to the hypervisor, mainly to make sure  
> everyone knows that it is disabled, but this TCL was still problematic.
> -JX
> 
> On Aug 20, 2006, at 1:12 PM, Xen patchbot-xenppc-unstable wrote:
> 
> > # HG changeset patch
> > # User Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
> > # Node ID a7abc95d4ce4177acd9cfbd58476d521352f9ff7
> > # Parent  6b9124f9d89d58eb81847813dc0043ba3896b919
> > [TOOLS] avoid shadow ops for POWERPC
> >
> > Signed-off-by: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
> > ---
> >  tools/python/xen/xend/XendDomainInfo.py |    9 ++++++---
> >  1 files changed, 6 insertions(+), 3 deletions(-)
> >
> > diff -r 6b9124f9d89d -r a7abc95d4ce4 tools/python/xen/xend/ 
> > XendDomainInfo.py
> > --- a/tools/python/xen/xend/XendDomainInfo.py       Sun Aug 20 13:02:16  
> > 2006 -0400
> > +++ b/tools/python/xen/xend/XendDomainInfo.py       Sun Aug 20 13:06:37  
> > 2006 -0400
> > @@ -1293,9 +1293,12 @@ class XendDomainInfo:
> >              # Make sure there's enough RAM available for the domain
> >              balloon.free(m + sm * 1024)
> >
> > -            # Set up the shadow memory
> > -            sm = xc.shadow_mem_control(self.domid, mb=sm)
> > -            self.info['shadow_memory'] = sm
> > +            if os.uname()[4] in ('ppc64'):
> > +                self.info['shadow_memory'] = 0
> > +            else:
> > +                # Set up the shadow memory
> > +                sm = xc.shadow_mem_control(self.domid, mb=sm)
> > +                self.info['shadow_memory'] = sm
> >
> >              init_reservation = self.info['memory'] * 1024
> >              if os.uname()[4] in ('ia64', 'ppc64'):

Would a workaround on the Xen side make this unnecessary? In fact it
seems the current Xen code should already work, since xend will only
call PPC's shadow_mem_control() with mb=0.

Can we back out the patch above?

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel