This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [XenPPC] [xenppc-unstable] [POWERPC] memory cleanup (phase 2), destr

To: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
Subject: Re: [XenPPC] [xenppc-unstable] [POWERPC] memory cleanup (phase 2), destroy (et. al) now work
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Mon, 14 Aug 2006 17:50:50 -0500
Cc: xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 14 Aug 2006 15:50:19 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C2377810-D9B4-47C3-81B3-E8FDA8BEC426@xxxxxxxxxxxxxx>
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <E1GCd1N-0006fH-1h@xxxxxxxxxxxxxxxxxxxxx> <1155589057.30510.130.camel@xxxxxxxxxxxxxxxxxxxxx> <C2377810-D9B4-47C3-81B3-E8FDA8BEC426@xxxxxxxxxxxxxx>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 2006-08-14 at 17:48 -0400, Jimi Xenidis wrote:
> On Aug 14, 2006, at 4:57 PM, Hollis Blanchard wrote:
> >
> > Why do we free the HTAB in arch_domain_destroy(),
> Xen heap
> > but free the RMA in
> > domain_relinquish_resources()?
> Domheap
> everytime you release !xenheap memory, it checks t->tot_pages and if  
> its zero releases a d->recnt. only when the refcnt = 1 (made zero by  
> destroy) will destroy get called.

OK, to expand on your answer a bit, the difference is that the HTAB is
allocated from the Xen heap, while the RMA is allocated from the domain
heap. We have to free all domain heap memory in
domain_relinquish_resources(), and only then will domain_destroy() be

I think it might make sense to allocate the HTAB from the domain heap
instead, but it's working for now...

Hollis Blanchard
IBM Linux Technology Center

Xen-ppc-devel mailing list