This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [XenPPC] [PATCH/RFC] Support Xen console=comX option

To: Amos Waterland <apw@xxxxxxxxxx>
Subject: Re: [XenPPC] [PATCH/RFC] Support Xen console=comX option
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Thu, 10 Aug 2006 11:25:34 -0500
Cc: xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 10 Aug 2006 09:25:04 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060809233714.GA7459@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <20060809233714.GA7459@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2006-08-09 at 19:37 -0400, Amos Waterland wrote:
> The below patch allows Xen/PPC to support the console=comX option 
> that Xen/x86 uses.  With this patch applied, one need simply 
> supply CMDLINE="console=com2" on the make invocation to get proper use
> of the physical serial port on a JS21.

Have you tried the (off-list) suggestion that was made for SLOF:
        setenv direct-serial? true

If that doesn't work, we need to complain to the SLOF guys. If it does
work, it sounds like that solves your problem?

Anyways, it looks like your patch is not specific to JS2x, isn't very
invasive, and provides useful functionality that x86 already has. So
it's OK with me after you do the following:
- update the copyright year at the top of the file
- I would prefer strcmp() rather than strstr() here
- put newlines after your if statements
- add a comment above the "pruning" loop explaining
  a) that we're pruning all serial devices other than the one pointed to
by /chosen/stdout
  b) why we need to prune anything at all


Hollis Blanchard
IBM Linux Technology Center

Xen-ppc-devel mailing list