WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

Re: [XenPPC] [rfc][patch][linux] ioctl32() compat plumbing for xen calls

To: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
Subject: Re: [XenPPC] [rfc][patch][linux] ioctl32() compat plumbing for xen calls
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Thu, 13 Jul 2006 11:42:31 -0500
Cc: virtualization@xxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 13 Jul 2006 09:42:15 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <E1G13dV-00047a-Ve@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <E1G13dV-00047a-Ve@xxxxxxxxxxxxxxxxxxx>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2006-07-13 at 12:01 -0400, Jimi Xenidis wrote:
> 
> diff -r dd6f9da2ed0bcf52deb9f48e24ae56b470e1afc6 -r 
> 2a6fda4e7dde1a0a5d29a62303e85bcea868eb47 drivers/xen/privcmd/Makefile
> --- a/drivers/xen/privcmd/Makefile      Thu Jul 13 11:40:56 2006 -0400
> +++ b/drivers/xen/privcmd/Makefile      Thu Jul 13 11:51:38 2006 -0400
> @@ -1,2 +1,2 @@
> -
> -obj-$(CONFIG_XEN_PRIVCMD)      := privcmd.o
> +compat_obj-y   := compat_privcmd.o
> +obj-$(CONFIG_XEN_PRIVCMD)      := privcmd.o $(compat_obj-$(CONFIG_COMPAT)) 

That's a curious use of CONFIG_XEN_PRIVCMD... I think it would make more
sense to use it in the parent directory:
diff -r 72c8bc5d88f4 drivers/xen/Makefile
--- a/drivers/xen/Makefile      Thu Jun 29 13:04:30 2006 -0400
+++ b/drivers/xen/Makefile      Thu Jul 13 11:33:30 2006 -0500
@@ -1,7 +1,7 @@ obj-y   += core/
 obj-y  += core/
 obj-y  += console/
 obj-y  += evtchn/
-obj-y  += privcmd/
+obj-$(CONFIG_XEN_PRIVCMD) += privcmd/
 obj-y  += xenbus/

 obj-$(CONFIG_XEN_UTIL)                 += util.o

diff -r 72c8bc5d88f4 drivers/xen/privcmd/Makefile
--- a/drivers/xen/privcmd/Makefile      Thu Jun 29 13:04:30 2006 -0400
+++ b/drivers/xen/privcmd/Makefile      Thu Jul 13 11:37:18 2006 -0500
@@ -1,2 +1,3 @@

-obj-$(CONFIG_XEN_PRIVCMD)      := privcmd.o
+obj-y := privcmd.o
+obj-$(CONFIG_COMPAT) += privcmd.o


There's no point in recursing into the directory in the first place if
the config variable isn't set...

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel

<Prev in Thread] Current Thread [Next in Thread>