Re: [XenPPC] small bug in exceptions.S?

On Tue, 2006-06-20 at 16:01 -0400, Mark F Mergen wrote:
> I don't have a failure case, but I noticed this while reading code at line
> 307 in xen/arch/ppc/ppc64/exceptions.S.  It seems to me that this code
> doesn't do what the comment says is intended.
> 
>     /* clear MSR:RI/EE to set SRR0/SRR1 */
>     mfmsr r0
>     li r13, 0
>     mtmsrd r0, 1
> 
> I believe correct code would be:
> 
>     li r0,0
>     mtmsrd r0, 1

Ugh, good catch.

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel

<Prev in Thread]	Current Thread	[Next in Thread>
[XenPPC] small bug in exceptions.S?, Mark F Mergen Re: [XenPPC] small bug in exceptions.S?, Hollis Blanchard <=

Previous by Date:

[XenPPC] small bug in exceptions.S?, Mark F Mergen

Next by Date:

[XenPPC] [xenppc-unstable] [ppc] Allow for the xen link address to be overridden, Xen patchbot-xenppc-unstable

Previous by Thread:

[XenPPC] small bug in exceptions.S?, Mark F Mergen

Next by Thread:

[XenPPC] [xenppc-unstable] [ppc] Allow for the xen link address to be overridden, Xen patchbot-xenppc-unstable

Indexes:

[Date] [Thread] [Top] [All Lists]