Re: [XenPPC] [xenppc-unstable] [ppc] implement new upstream loca

On Tue, 2006-06-13 at 10:58 -0400, Jimi Xenidis wrote:
> On Jun 12, 2006, at 3:22 PM, Xen patchbot-xenppc-unstable wrote:
> > +static inline int local_event_delivery_is_enabled(void)
> > +{
> > +    return vcpu_regs(current)->msr & MSR_EE;
> > +}
> 
> NIT: if would be safer if this returned 0 or 1 rather than 0 or MSR_EE

I had decided against it, since I figured the places doing the binary
(rather than logical) operations could be responsible for that.

However, x86 local_event_delivery_is_enabled() only returns 0 or 1, so
to avoid subtle problems in the future I'll change ours to match. We're
only talking about a couple instructions anyways...

-- 
Hollis Blanchard
IBM Linux Technology Center

_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel

<Prev in Thread]	Current Thread	[Next in Thread>
*[XenPPC] [xenppc-unstable] [ppc] implement new upstream local_event_delivery_ interface*, Xen patchbot-xenppc-unstable* *Re: [XenPPC] [xenppc-unstable] [ppc] implement new upstream local_event_delivery_ interface*, Jimi Xenidis* *Re: [XenPPC] [xenppc-unstable] [ppc] implement new upstream local_event_delivery_ interface*, Hollis Blanchard* <=

Previous by Date:

Re: [XenPPC] [xenppc-unstable] [ppc] implement new upstream local_event_delivery_* interface, Jimi Xenidis

Next by Date:

[XenPPC] [xenppc-unstable] [ppc] make local_event_delivery_is_enabled() return only 1 or 0, Xen patchbot-xenppc-unstable

Previous by Thread:

Re: [XenPPC] [xenppc-unstable] [ppc] implement new upstream local_event_delivery_* interface, Jimi Xenidis

Next by Thread:

[XenPPC] [xenppc-unstable] [ppc] make local_event_delivery_is_enabled() return only 1 or 0, Xen patchbot-xenppc-unstable

Indexes:

[Date] [Thread] [Top] [All Lists]