WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

Re: [XenPPC] [pushed] [ppc] fix open pic initalization for g5.

To: xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [XenPPC] [pushed] [ppc] fix open pic initalization for g5.
From: Maria Butrico <butrico@xxxxxxxxxxxxx>
Date: Tue, 23 May 2006 07:53:46 -0400
Delivery-date: Tue, 23 May 2006 04:54:37 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1148329831.29273.20.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E1FiGhl-00018R-M8@xxxxxxxxxxxxxxxxxxxxx> <1148329831.29273.20.camel@xxxxxxxxxxxxxxxxxxxxx>
Reply-to: butrico@xxxxxxxxxxxxxx
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.2 (Windows/20060308)
Hollis Blanchard wrote:
static int find_mpic(void)
{
    ...
    rc = find_mpic_simple_probe(oft_p);

    if (rc < 0) {
        DBG("%s: Searching for pic ...\n", __func__);
        rc = find_mpic_canonical_probe(oft_p);
    }

    return rc;
}

Aside from some stylistic issues around 'opic_flags', why do we even
have two paths here? If the "canonical" probe always works, let's always
use it.

The canonical probe does not work on mambo. I have not tested the canonical probe on a maple. The canonical probe does not work on a js20, where we might have to switch at looking at the content of the property compatible. However this also requires slightly different interfaces against the ofd tree, the compatible property consisting of null separated string, and our required match going against a subset of the value of said property.

I can work on this another couple of days truly, but I do not consider this priority. Let discuss at status how should we in general approach these problems.



_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel

<Prev in Thread] Current Thread [Next in Thread>