Re: [XenPPC] [pushed] [ppc] OF write method does not handle carriage return

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Tue, 2006-04-25 at 16:46 -0400, Jimi Xenidis wrote:
> On Apr 25, 2006, at 3:53 PM, Hollis Blanchard wrote:
> >> +                if (rc == OF_FAILURE) return rc;
> >
> > Please add a newline after the conditional.
> 
> Nah, Its valid, readable and simpler, I see no reason to change it.

It is also inconsistent with Xen and Linux style. So does our use of
braces for single-line conditionals in PPC code, for that matter, but it
seems we are all in agreement on that one, and we are not on this one.

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel