 Home |
Products |
Support |
Community |
News |
xen-merge
Re: [Xen-merge] [PATCH] merge i386's agp.h
| To: | Jan Beulich <JBeulich@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-merge] [PATCH] merge i386's agp.h |
| From: | Christian Limpach <Christian.Limpach@xxxxxxxxxxxx> |
| Date: | Thu, 22 Dec 2005 15:08:20 +0000 |
| Cc: | xen-merge@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Thu, 22 Dec 2005 15:11:12 +0000 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <43A81FF4.76F0.0078.0@xxxxxxxxxx> |
| List-help: | <mailto:xen-merge-request@lists.xensource.com?subject=help> |
| List-id: | xen-merge <xen-merge.lists.xensource.com> |
| List-post: | <mailto:xen-merge@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-merge>, <mailto:xen-merge-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-merge>, <mailto:xen-merge-request@lists.xensource.com?subject=unsubscribe> |
| References: | <43A81FF4.76F0.0078.0@xxxxxxxxxx> |
| Sender: | xen-merge-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Mutt/1.4.1i |
On Tue, Dec 20, 2005 at 03:15:00PM +0100, Jan Beulich wrote:
> Subject says it all.
How about having a mach-{default,xen}/mach_agp.h file included at the top
of agp.h with:
#define phys_to_gart(x) phys_to_machine(x)
#define gart_to_phys(x) machine_to_phys(x)
#define HAVE_MACH_PHYS_GART_MACROS
and then in asm-i386/agp.h:
/* Convert a physical address to an address suitable for the GART. */
#ifndef HAVE_MACH_PHYS_GART_MACROS
#define phys_to_gart(x) (x)
#define gart_to_phys(x) (x)
#endif
Same for the {alloc,free}_gatt_pages macros.
That would be my preference since it preserves the default definitions
in the regular file moving the overrides into machine specific files.
christian
_______________________________________________
Xen-merge mailing list
Xen-merge@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-merge
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-merge] [PATCH] export pm_power_off on i386, Jan Beulich |
|---|---|
| Next by Date: | Re: [Xen-merge] [PATCH] merge i386's agp.h, Jan Beulich |
| Previous by Thread: | [Xen-merge] [PATCH] merge i386's pgalloc.h, Jan Beulich |
| Next by Thread: | Re: [Xen-merge] [PATCH] merge i386's agp.h, Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
