xen-merge

[Top] [All Lists]

Re: [Xen-merge] questions (resend)

from [Jan Beulich]

[Permanent Link][Original]

To:	"Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject:	Re: [Xen-merge] questions (resend)
From:	"Jan Beulich" <JBeulich@xxxxxxxxxx>
Date:	Thu, 22 Dec 2005 11:28:03 +0100
Cc:	xen-merge@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Thu, 22 Dec 2005 10:29:57 +0000
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<355d16107611cbe3c69b044d52f293ad@xxxxxxxxxxxx>
List-help:	<mailto:xen-merge-request@lists.xensource.com?subject=help>
List-id:	xen-merge <xen-merge.lists.xensource.com>
List-post:	<mailto:xen-merge@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-merge>, <mailto:xen-merge-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-merge>, <mailto:xen-merge-request@lists.xensource.com?subject=unsubscribe>
References:	<43A84607.76F0.0078.0@xxxxxxxxxx> <355d16107611cbe3c69b044d52f293ad@xxxxxxxxxxxx>
Sender:	xen-merge-bounces@xxxxxxxxxxxxxxxxxxx

>> include/asm-i386/mach-xen/asm/setup.h
>> - What is the 'unsigned long long' override for PFN_PHYS good for
(and
>>   if for anything, why isn't standard Linux in need of this in PAE
>>   mode)?
>
>It must have got added at some point to fix a problem on >4GB boxes, 
>but now I can't see any use of PFN_PHYS where the result can
reasonably 
>be larger than 4GB. Perhaps the offending usage got removed. I think 
>this modification to PFN_PHYS shouldn't get merged.

I actually disagree after a second inspection: At least the use in the
call to add_memory_region() (in
include/asm-i386/mach-xen/setup_arch_post.h) doesn't work right without
that cast. I will, however, remove the cast in the header anyway and
rather add one in that place.

Jan

_______________________________________________
Xen-merge mailing list
Xen-merge@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-merge

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-merge] questions (resend), Jan Beulich Re: [Xen-merge] questions (resend), Keir Fraser Re: [Xen-merge] questions (resend), Jan Beulich <= Re: [Xen-merge] questions (resend), Keir Fraser

Previous by Date:	Re: [Xen-merge] CONFIG_XEN vs. CONFIG_X86{,_64}_XEN, James Bulpin
Next by Date:	Re: [Xen-merge] questions (resend), Keir Fraser
Previous by Thread:	Re: [Xen-merge] questions (resend), Keir Fraser
Next by Thread:	Re: [Xen-merge] questions (resend), Keir Fraser
Indexes:	[Date] [Thread] [Top] [All Lists]