WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/

Home

xen-merge

[Top] [All Lists]

Re: [Xen-merge] [PATCH] merge i386's agp.h

from [Vincent Hanquez]

[Permanent Link][Original]

To:	Jan Beulich <JBeulich@xxxxxxxxxx>
Subject:	Re: [Xen-merge] [PATCH] merge i386's agp.h
From:	Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxx>
Date:	Tue, 20 Dec 2005 19:01:37 +0100
Cc:	xen-merge@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Tue, 20 Dec 2005 18:04:12 +0000
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<43A81FF4.76F0.0078.0@xxxxxxxxxx>
List-help:	<mailto:xen-merge-request@lists.xensource.com?subject=help>
List-id:	xen-merge <xen-merge.lists.xensource.com>
List-post:	<mailto:xen-merge@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-merge>, <mailto:xen-merge-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-merge>, <mailto:xen-merge-request@lists.xensource.com?subject=unsubscribe>
References:	<43A81FF4.76F0.0078.0@xxxxxxxxxx>
Sender:	xen-merge-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mutt/1.5.9i

On Tue, Dec 20, 2005 at 03:15:00PM +0100, Jan Beulich wrote:
> Subject says it all.

I'm not sure that is the right approch. Adding ifdef all over [1]
has never been well accepted by kernel people ...

But it look backwards from Chris' approch to split files into mach and
generic (especially floppy.h)
(which is, imho not nicer on a certain POV.)

Maybe a mix of the two would be the `cleanest' [2] solution.

[1] there's not that much ifdef so "all over" is a bit strong here ...
[2] I'm afraid there's no such thing here ..
-- 
Vincent Hanquez

_______________________________________________
Xen-merge mailing list
Xen-merge@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-merge

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-merge] [PATCH] merge i386's floppy.h, (continued) [Xen-merge] [PATCH] merge i386's floppy.h, Jan Beulich [Xen-merge] [PATCH] merge i386's highmem.h, Jan Beulich [Xen-merge] [PATCH] merge i386's hw_irq.h, Jan Beulich [Xen-merge] [PATCH] move i386's hypercall.h, Jan Beulich [Xen-merge] [PATCH] move i386's hypervisor.h, Jan Beulich [Xen-merge] [PATCH] move i386's swiotlb.h, Jan Beulich Re: [Xen-merge] [PATCH] move i386's swiotlb.h, Vincent Hanquez Re: [Xen-merge] [PATCH] move i386's swiotlb.h, Jan Beulich Re: [Xen-merge] [PATCH] move i386's swiotlb.h, Vincent Hanquez Re: [Xen-merge] [PATCH] move i386's swiotlb.h, Muli Ben-Yehuda Re: [Xen-merge] [PATCH] merge i386's agp.h, Vincent Hanquez <= Re: [Xen-merge] [PATCH] merge i386's agp.h, Jan Beulich [Xen-merge] [PATCH] merge i386's kmap_types.h, Jan Beulich [Xen-merge] [PATCH] merge i386's mmu.h, Jan Beulich [Xen-merge] [PATCH] merge i386's mmu_context.h, Jan Beulich [Xen-merge] [PATCH] merge i386's pci.h, Jan Beulich [Xen-merge] [PATCH] merge i386's io.h, Jan Beulich [Xen-merge] [PATCH] merge i386's page.h, Jan Beulich *[Xen-merge] [PATCH] merge i386's pgtable.h*, Jan Beulich* [Xen-merge] [PATCH] merge i386's segment.h, Jan Beulich [Xen-merge] [PATCH] merge i386's processor.h, Jan Beulich

Previous by Date:	Re: [Xen-merge] questions (resend), Keir Fraser
Next by Date:	Re: [Xen-merge] disallow CONFIG_PCI_MSI, Vincent Hanquez
Previous by Thread:	Re: [Xen-merge] [PATCH] move i386's swiotlb.h, Muli Ben-Yehuda
Next by Thread:	Re: [Xen-merge] [PATCH] merge i386's agp.h, Jan Beulich
Indexes:	[Date] [Thread] [Top] [All Lists]

This site is hosted by Citrix