WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-merge

Re: [Xen-merge] io_apic.c, part 1

To: Andi Kleen <ak@xxxxxxx>
Subject: Re: [Xen-merge] io_apic.c, part 1
From: "Martin J. Bligh" <mbligh@xxxxxxxxxx>
Date: Mon, 08 Aug 2005 09:27:53 -0700
Cc: xen-merge <xen-merge@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 08 Aug 2005 16:26:01 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <419330000.1123516989@[10.10.2.4]>
List-help: <mailto:xen-merge-request@lists.xensource.com?subject=help>
List-id: xen-merge <xen-merge.lists.xensource.com>
List-post: <mailto:xen-merge@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-merge>, <mailto:xen-merge-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-merge>, <mailto:xen-merge-request@lists.xensource.com?subject=unsubscribe>
References: <416790000.1123515818@[10.10.2.4]><20050808155328.GB26249@xxxxxxxxxxxxx> <419330000.1123516989@[10.10.2.4]>
Reply-to: "Martin J. Bligh" <mbligh@xxxxxxxxxx>
Sender: xen-merge-bounces@xxxxxxxxxxxxxxxxxxx

--"Martin J. Bligh" <mbligh@xxxxxxxxxx> wrote (on Monday, August 08, 2005 
09:03:09 -0700):

> 
> 
> --Andi Kleen <ak@xxxxxxx> wrote (on Monday, August 08, 2005 17:53:28 +0200):
> 
>> On Mon, Aug 08, 2005 at 08:43:38AM -0700, Martin J. Bligh wrote:
>>> This just shoves some ifdef wrappers around whole functions to
>>> either not define them, or provide a no-op function instead.
>>> The alternative to this is to split the file, but I tried that,
>>> and it made an unholy mess. Plus it's much nicer for maintainance
>>> to keep the alternative definitions right next to each other, if
>>> it's this trivial.
>> 
>> I would prefer to just replace apic.c/io_apic.c completely with new
>> files in the Xen case and perhaps factor the still needed functions out.
>> That's much better than ifdef mess and apic/io_apic needed some
>> cleanup anyways.
> 
> Try doing it then, and you'll see what a mess it makes ;-)

I'll have another play with it later. Just reluctant to waste yet
more time moving shit around if Andrew isn't going to take the results
upstream.

M.


_______________________________________________
Xen-merge mailing list
Xen-merge@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-merge

<Prev in Thread] Current Thread [Next in Thread>