WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-merge

Re: [Xen-merge] Odd diff in mpparse.c

To: "Martin J. Bligh" <mbligh@xxxxxxxxxx>
Subject: Re: [Xen-merge] Odd diff in mpparse.c
From: Andi Kleen <ak@xxxxxxx>
Date: Fri, 5 Aug 2005 23:32:25 +0200
Cc: xen-merge <xen-merge@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 05 Aug 2005 21:30:48 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <138230000.1123219658@[10.10.2.4]>
List-help: <mailto:xen-merge-request@lists.xensource.com?subject=help>
List-id: xen-merge <xen-merge.lists.xensource.com>
List-post: <mailto:xen-merge@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-merge>, <mailto:xen-merge-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-merge>, <mailto:xen-merge-request@lists.xensource.com?subject=unsubscribe>
References: <138230000.1123219658@[10.10.2.4]>
Sender: xen-merge-bounces@xxxxxxxxxxxxxxxxxxx
> Later down there's this:
> 
> -       unsigned long *bp = phys_to_virt(base);
> +       unsigned long *bp = isa_bus_to_virt(base);
> 
> 
> which makes rather more sense to me. If anyone can make more sense of that
> bit than me, would help to slap me with it.

It's still reading it from the direct mapping.

You could always switch over to ioremap(). Or just use ACPI which
handles this properly.

-Andi

_______________________________________________
Xen-merge mailing list
Xen-merge@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-merge

<Prev in Thread] Current Thread [Next in Thread>