WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [patch] IA64: request_irq_vector() Return an error

To: Simon Horman <horms@xxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] [patch] IA64: request_irq_vector() Return an error if setup_vector() fails
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Mon, 2 Mar 2009 16:52:45 +0900
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sun, 01 Mar 2009 23:52:49 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090224021207.GA18089@xxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20090224021207.GA18089@xxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.6i
Applied with trivial modificatios.

thanks,

On Tue, Feb 24, 2009 at 01:12:07PM +1100, Simon Horman wrote:
> This is consistent with the x86 version of this function.
> 
> Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
> 
> --- 
> 
> Compile-tested only.
> 
> Index: xen-unstable.hg/xen/arch/ia64/linux-xen/irq_ia64.c
> ===================================================================
> --- xen-unstable.hg.orig/xen/arch/ia64/linux-xen/irq_ia64.c   2009-02-24 
> 09:11:25.000000000 +1100
> +++ xen-unstable.hg/xen/arch/ia64/linux-xen/irq_ia64.c        2009-02-24 
> 13:08:42.000000000 +1100
> @@ -243,7 +243,7 @@ static struct irqaction ipi_irqaction = 
>  #endif
>  
>  #ifdef XEN
> -extern void setup_vector (unsigned int vec, struct irqaction *action);
> +extern int setup_vector (unsigned int vec, struct irqaction *action);
>  #endif
>  
>  void
> @@ -276,7 +276,7 @@ int request_irq_vector(unsigned int vect
>               unsigned long irqflags, const char * devname, void *dev_id)
>  {
>       struct irqaction * action;
> -     int retval=0;
> +     int retval;
>  
>       /*
>        * Sanity-check: shared interrupts must pass in a real dev-ID,
> @@ -295,7 +295,8 @@ int request_irq_vector(unsigned int vect
>       action->handler = handler;
>       action->name = devname;
>       action->dev_id = dev_id;
> -     setup_vector(vector, action);
> +
> +     retval = setup_vector(vector, action);
>       if (retval)
>               xfree(action);
>  
> 
> _______________________________________________
> Xen-ia64-devel mailing list
> Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-ia64-devel
> 

-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [Xen-ia64-devel] [patch] IA64: request_irq_vector() Return an error if setup_vector() fails, Isaku Yamahata <=