WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

RE: [Xen-ia64-devel] [PATCH] Fix that guest can not get continuous memor

To: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Subject: RE: [Xen-ia64-devel] [PATCH] Fix that guest can not get continuous memory for vhpt
From: "Zhang, Yang" <yang.zhang@xxxxxxxxx>
Date: Thu, 19 Feb 2009 14:20:02 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-ia64-devel@xxxxxxxxxxxxxxxxxxx" <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 18 Feb 2009 22:23:25 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090219053236.GG19443%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <10C63FAD690C13458F0B32BCED571F1406BFDE2F@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20090219031203.GE19443%yamahata@xxxxxxxxxxxxx> <10C63FAD690C13458F0B32BCED571F1406BFE692@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20090219053236.GG19443%yamahata@xxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcmSU4Fqx7j1uocGTeiVXOKJc213fwABeV8g
Thread-topic: [Xen-ia64-devel] [PATCH] Fix that guest can not get continuous memory for vhpt
Ok, I will modify it.
Thanks 
Best Regards
--yang

>-----Original Message-----
>From: Isaku Yamahata [mailto:yamahata@xxxxxxxxxxxxx]
>Sent: 2009年2月19日 13:33
>To: Zhang, Yang
>Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
>Subject: Re: [Xen-ia64-devel] [PATCH] Fix that guest can not get continuous
>memory for vhpt
>
>On Thu, Feb 19, 2009 at 01:11:53PM +0800, Zhang, Yang wrote:
>> Hi
>>
>> >From: Isaku Yamahata [mailto:yamahata@xxxxxxxxxxxxx]
>> >Sent: 2009年2月19日 11:12
>> >To: Zhang, Yang
>> >Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
>> >Subject: Re: [Xen-ia64-devel] [PATCH] Fix that guest can not get continuous
>> >memory for vhpt
>> >- It is a poor approach to introduce new HVM_PARAM_VHPT_SIZE.
>> >  This is inconsistent with XEN_DOMCTL_arch_setup by which libxc tells
>> >  VMM vhpt size of PV domain.
>> >  So the first idea which came into my mind is to call
>> >  XEN_DOMCTL_ARCH_setup before populating domain memory.
>> >  I haven't checked if it's possible or not, though. Maybe we can introduce
>> >  new XEN_DOMAINSETUP_xxx flag.
>>      I doesn't introduce HVM_PARAM_VHPT_SIZE. The hvm needs it to save the
>vhpt'size for allocating vhpt's memory when vcpu boot. I just add some code to
>save memory for vhpt beforehand when libxc tells VMM vhpt size of  hvm. And I
>don't think PV domain need to do this.
>
>Oh, sorry. I misread it. Okay, so the approach looks sane.
>
>- The functions newly added in arch/ia64/xen/domain.c are hvm domain
>  specific. So please move them under arch/ia64/xen/vmx/.
>
>- The pages for vhpt is allocated by alloc_domheap_pages(NULL, ...),
>  Thus those memory doesn't accounted to the domain.
>  So adjusting domain memory size doesn't make sense. Just drop it.
>
>- Is vhpt_page[] really necessary?
>  How about setting hcb->hash directly instead of temporary
>  keeping it in vhpt_page[]?
>  Probably adjusting codes of resource allocating/freeing might be required,
>  though.
>
>thanks,
>--
>yamahata
_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel