WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

RE: [Xen-ia64-devel][PATCH][VTD] small patches for VTD

To: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Subject: RE: [Xen-ia64-devel][PATCH][VTD] small patches for VTD
From: "Xu, Anthony" <anthony.xu@xxxxxxxxx>
Date: Thu, 23 Oct 2008 11:16:16 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 22 Oct 2008 20:16:26 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20081023024404.GF15025%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <F7C8A4D3A9905B45A80E4C194793FA6501B3130ED5@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20081022053201.GE8110%yamahata@xxxxxxxxxxxxx> <F7C8A4D3A9905B45A80E4C194793FA6501B31316B5@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20081023015608.GC15025%yamahata@xxxxxxxxxxxxx> <F7C8A4D3A9905B45A80E4C194793FA6501B3131A24@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20081023022420.GD15025%yamahata@xxxxxxxxxxxxx> <F7C8A4D3A9905B45A80E4C194793FA6501B3131A92@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20081023024404.GF15025%yamahata@xxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ack0uUHqXF25teh6Qzq8VGNF0lnw4gAA8E7Q
Thread-topic: [Xen-ia64-devel][PATCH][VTD] small patches for VTD
Isaku Yamahata wrote:
> On Thu, Oct 23, 2008 at 10:31:20AM +0800, Xu, Anthony wrote:
>> Iommu_un/map_page does nothing for PV domain.
>> Why is there a race?
>
> Oh sorry. I'm not very familiar with iommu code (yet).
> My understanding is
>   iommu_domain_init() is called unconditionaly by arch_domain_create()
>   so that platform_ops is initialized.
>   iommu_(un)map_page() checks iommu_enabled and whether platform_ops
>   is initialized. Thus iommu_(un)map_page() manipulates iommu page
>   table even for PV domain.
>
> Clearly I'm missing something important. Could you enlighten me?

Acctually I missed something.
First, PV domain can use VTD in x86 side.
So before calling iommu_(un)map_page, Xen needs to check if it is needed.


 if ( iommu_enabled && (is_hvm_domain(d) || need_iommu(d)) )
    {

I'll update the patch

Thanks,
Anthony


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel