RE: [Xen-devel] Re: [Xen-ia64-devel] [PATCH 0/3] IA64: add cpufreq support

["Lu, Guanqun" <guanqun.lu@xxxxxxxxx>]

>-----Original Message-----
>From: Isaku Yamahata [mailto:yamahata@xxxxxxxxxxxxx]
>Sent: Tuesday, October 07, 2008 6:29 PM
>To: Yu, Ke
>Cc: xen-devel@xxxxxxxxxxxxxxxxxxx;
>xen-ia64-devel@xxxxxxxxxxxxxxxxxxx; Lu, Guanqun
>Subject: Re: [Xen-devel] Re: [Xen-ia64-devel] [PATCH 0/3]
>IA64: add cpufreq support
>
>Hi Yu. I tested it and have some comments.
>
>- When I run xenpm, xen panics
>  It panics at 0xf40000000406ba91 =
>  xen-unstable.hg/xen/drivers/acpi/pmstat.c:98 (addr2line told)
>  It looks like pxpt->u.pt[pxpt->u.cur] wasn't allocated yet resulting
>  in NULL pointer reference.
>
>- From the boot message, ondemand governor fails to load.
>  I'm not sure this error is expected because of my hardware.
>  I guess this error case haven't been tested and that it caused
>  the above panic.
>
>- I added work around to avoid the above panic, but
>  xenpm needs the following patch to get the following result.
>  NOTE: hyperthreading is enabled.
>
>
[...]

>-            ret = xc_pm_get_pxstat(xc_fd, 0, pxstat);
>+            ret = xc_pm_get_pxstat(xc_fd, i, pxstat);

A simple copy leaves bugs behind...
Many thanks!


>             if( ret ) {
>                 fprintf(stderr, "failed to get P-states
>statistics information\n");
>                 free(pxstat->trans_pt);
>                 free(pxstat->pt);
>-                break;
>+                continue;

The other changes from 'break' to 'continue' seem reasonable for your 
hyperthreading configuration.
But people may get unhappy when he sees lots of the same message.

>             }
>
>             printf("cpu id               : %d\n", i);
>
>
>---
>result of xenpm
>
># ./xenpm
>Xen cpuidle is not enabled!
>Xen cpuidle is not enabled!
>Xen cpuidle is not enabled!
>Xen cpuidle is not enabled!
>Xen cpuidle is not enabled!
>Xen cpuidle is not enabled!
>Xen cpuidle is not enabled!
>Xen cpuidle is not enabled!
>failed to get max P-state
>cpu id               : 1
>total P-states       : 3
>usable P-states      : 3
>current frequency    : 1048575 MHz
>*P0                  : freq       [1048575 MHz]
>                       transition [00000000000000000000]
>                       residency  [00000000000000004361 ms]
>P1                   : freq       [1048575 MHz]
>                       transition [00000000000000000000]
>                       residency  [00000000000000000000 ms]
>P2                   : freq       [1048575 MHz]
>                       transition [00000000000000000000]
>                       residency  [00000000000000000000 ms]
>
>failed to get max P-state
>cpu id               : 3
>total P-states       : 3
>usable P-states      : 3
>current frequency    : 1048575 MHz
>*P0                  : freq       [1048575 MHz]
>                       transition [00000000000000000000]
>                       residency  [00000000000000004781 ms]
>P1                   : freq       [1048575 MHz]
>                       transition [00000000000000000000]
>                       residency  [00000000000000000000 ms]
>P2                   : freq       [1048575 MHz]
>                       transition [00000000000000000000]
>                       residency  [00000000000000000000 ms]
>
>failed to get max P-state
>cpu id               : 5
>total P-states       : 3
>usable P-states      : 3
>current frequency    : 1048575 MHz
>*P0                  : freq       [1048575 MHz]
>                       transition [00000000000000000000]
>                       residency  [00000000000000004507 ms]
>P1                   : freq       [1048575 MHz]
>                       transition [00000000000000000000]
>                       residency  [00000000000000000000 ms]
>P2                   : freq       [1048575 MHz]
>                       transition [00000000000000000000]
>                       residency  [00000000000000000000 ms]
>
>failed to get max P-state
>cpu id               : 7
>total P-states       : 3
>usable P-states      : 3
>current frequency    : 1048575 MHz
>*P0                  : freq       [1048575 MHz]
>                       transition [00000000000000000000]
>                       residency  [00000000000000005799 ms]
>P1                   : freq       [1048575 MHz]
>                       transition [00000000000000000000]
>                       residency  [00000000000000000000 ms]
>P2                   : freq       [1048575 MHz]
>                       transition [00000000000000000000]
>                       residency  [00000000000000000000 ms]
>
>
[...]

>
>--
>yamahata
>



--
Guanqun

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel