WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

[Xen-ia64-devel] Re: [PATCH 01/23] ia64/xen: introduce synch bitops whic

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-ia64-devel] Re: [PATCH 01/23] ia64/xen: introduce synch bitops which is necessary for ia64/xen support.
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Wed, 9 Apr 2008 18:01:39 +0900
Cc: virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 09 Apr 2008 02:01:56 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <47FC4F9F.4060301@xxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <12077166301391-git-send-email-yamahata@xxxxxxxxxxxxx> <12077166303062-git-send-email-yamahata@xxxxxxxxxxxxx> <47FC4F9F.4060301@xxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.6i
On Wed, Apr 09, 2008 at 12:09:51AM -0500, Jeremy Fitzhardinge wrote:

> >+#define sync_cmpxchg        ia64_cmpxchg4_acq
> >  
> 
> Please always use arguments with function-like macros, to prevent 
> accidental namespace clashes.

Will fix.

> >+#define sync_cmpxchg_subword sync_cmpxchg
> >  
> 
> Ditto.

It looks like that sync_cmpxchg_subword isn't used any more.
Is it safe to eliminate sync_cmpxchg_subword?

-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel