Re: [Xen-ia64-devel][PATCH]PAL virtualization service related patch

[Alex Williamson <alex.williamson@xxxxxx>]

Hi Anthony,

   Could you add prototypes to the appropriate header files and include
them so we can avoid this extern kludgy-ness?  I think a descriptive
comment for this function would also be worthwhile.  Thanks,

        Alex

On Sat, 2008-03-29 at 16:17 +0800, Xu, Anthony wrote:
> --- a/xen/arch/ia64/vmx/vmx_init.c      Fri Mar 14 15:07:45 2008 -0600
> +++ b/xen/arch/ia64/vmx/vmx_init.c      Sat Mar 29 15:32:55 2008 +0800
> @@ -63,6 +63,33 @@ u64 __vsa_base = 0;  /* Run-time service 
>  u64 __vsa_base = 0;    /* Run-time service base of VMX */
>  
>  /* Check whether vt feature is enabled or not. */
> +
> +void vmx_vps_patch(void)
> +{
> +       extern void ia64_patch_imm64 (u64 , u64 );
> +       extern char vmx_vps_sync_read;
> +       extern char vmx_vps_sync_write;
> +       extern char vmx_vps_resume_normal;
> +       extern char vmx_vps_resume_handler;
> +       u64 addr;
-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel