WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [PATCH] Cleanup vcpu.h

To: Kouya Shimura <kouya@xxxxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] [PATCH] Cleanup vcpu.h
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Fri, 28 Mar 2008 15:18:41 -0600
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 28 Mar 2008 14:18:57 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <7kwsnpexbp.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: OSLO R&D
References: <7kwsnpexbp.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
   It seems like a good time to remove some of these old krufty comments
and previous implementations too (subset below).  Could you resubmit
with these scrubbed out?  Thanks,

        Alex

On Wed, 2008-03-26 at 16:52 +0900, Kouya Shimura wrote:
> +static inline IA64FAULT vcpu_get_iipa(VCPU * vcpu, u64 * pval)
> +{
> +       u64 val = PSCB(vcpu, iipa);
> +       // SP entry code does not save iipa yet nor does it get
> +       //  properly delivered in the pscb
> +//     printk("*** vcpu_get_iipa: cr.iipa not fully implemented yet!!
> \n");
> +       *pval = val;
> +       return IA64_NO_FAULT;
> +}
> +
> +static inline IA64FAULT vcpu_get_ifs(VCPU * vcpu, u64 * pval)
> +{
> +       //PSCB(vcpu,ifs) = PSCB(vcpu)->regs.cr_ifs;
> +       //*pval = PSCB(vcpu,regs).cr_ifs;
> +       *pval = PSCB(vcpu, ifs);
> +       return IA64_NO_FAULT;
> +}
-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>