WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

RE: [Xen-ia64-devel] pv_ops: ministate.h typo fix

To: "Isaku Yamahata" <yamahata@xxxxxxxxxxxxx>
Subject: RE: [Xen-ia64-devel] pv_ops: ministate.h typo fix
From: "Dong, Eddie" <eddie.dong@xxxxxxxxx>
Date: Thu, 27 Mar 2008 12:20:37 +0800
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 26 Mar 2008 21:22:24 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080327034137.GH29232%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <10EA09EFD8728347A513008B6B0DA77A02EF90BF@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20080327034137.GH29232%yamahata@xxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AciPvKQLXRQ29U5PRMqshn0AAg9QtAABFbJw
Thread-topic: [Xen-ia64-devel] pv_ops: ministate.h typo fix
Isaku Yamahata wrote:
> Hi Eddie.
> The attached patches does many things. Could you explain?
> 
> - convert cover argument in SAVE_MIN_WITH_COVER(_R19) into COVER.
>   This seems correct. I'll take this part.
> 
> - convert __COVER argument into COVER.
>   Using conflicting argument is a bad practice.

This is what original Linux uses, I think we don't need to convert from
COVER to __COVER which I guess you think it is as a cover instruction.

> 
> - shuffle instructions of XEN_BSW_1 and xen DO_XEN_MIN().
>   Is this for producing better bundles? Please ellaborate on this.
>   If so, I'll take as another patch.

??? Which code are u talking for?

> 
> - churning header file inclusion.
>   I need to rethink to do this with another mail you posted as
>   where to compile. I'll answer it to that mail.
>   I'm now inclined to move ia64/kernel/minstate.h under
>   include/asm-ia64/native/.

This is not in my patch, right?
If you want to remove it back & forth, can u do after my queueing
patch is taken or modified since rebase is headache.

Thanks, eddie

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel