WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [Patch] linux: need to set psr.ac inpage_fault

To: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] [Patch] linux: need to set psr.ac inpage_fault
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Mon, 24 Mar 2008 09:22:06 -0600
Cc: xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 24 Mar 2008 08:22:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <5BC88D946BA05Etakebe_akio@xxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: OSLO R&D
References: <44C889C7A28595takebe_akio@xxxxxxxxxxxxxx> <1206044344.27908.131.camel@bling> <5BC88D946BA05Etakebe_akio@xxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 2008-03-24 at 18:49 +0900, Akio Takebe wrote:
> >On Wed, 2008-03-19 at 22:46 +0900, Akio Takebe wrote:
> >>         ;;
> >> +#ifdef PSR_DEFAULT_BITS
> >> +       sum PSR_DEFAULT_BITS
> >> +#endif
> >
> >   How would we ever get here w/o PSR_DEFAULT_BITS defined?  Thanks,
> >
> I have tested with/without the patch, nothing happened.
> But I wanted to be the same as native linux.

Hi Akio,

   My comment is whether it's redundant to have the #ifdef
PSR_DEFAULT_BITS surrounding setting the user mask.  AFAICT, we can't
get to this code w/o PSR_DEFAULT_BITS set, so it seems unnecessary to
test for it.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel