This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-ia64-devel] [PATCH] Fix the domain refernece counting

To: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-ia64-devel] [PATCH] Fix the domain refernece counting
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Thu, 31 Jan 2008 14:01:04 +0900
Delivery-date: Wed, 30 Jan 2008 21:01:20 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.6i
Fix the domain refernece counting caused by allocated pages from domheap for
shared page and hyperregister page.
Calling share_xen_page_with_guest() with domain heap page is wrong so that
it increments domian->xenpages which is never decremented. Thus the domian
refcount doesn't decrease to 0 so that destroy_domain() is never called.
This patch make the allocation done from xenheap again.

The other way to fix it is to work around domain->xenheap and the page
refrence count somehow, but it would be very ugly. The right way to do so
is to enhance the xen page allocator to be aware of this kind of page
in addition to xenheap and domheap. But we don't want to touch the
common code.
And given that the limitation on xenheap of xen/ia64 is much relaxed,
probably it isn't necessary to be so nervouse not to allocate those pages
from xenheap.
If it happend to be necessary to allocate those pages from domheap,
we could address it at that time. For now just allocate them from


Attachment: 16926_69817752a068.patch
Description: Text Data

Xen-ia64-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>