Re: [Xen-ia64-devel] [RFC][PATCH 2/3] xen&domain gdb debugger

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

On Mon, Jan 21, 2008 at 09:21:04PM +0900, Kouya Shimura wrote:
Content-Description: message body text

> diff -r ff90abf572f2 -r dc1d6b4bae38 xen/arch/ia64/xen/mm.c
> --- a/xen/arch/ia64/xen/mm.c  Fri Jan 18 14:11:20 2008 -0700
> +++ b/xen/arch/ia64/xen/mm.c  Mon Jan 21 20:20:20 2008 +0900
> @@ -1403,6 +1403,13 @@ zap_domain_page_one(struct domain *d, un
>      if (pte_none(*pte))
>          return;
>  
> +#ifdef CONFIG_XEN_IA64_DEBUG_XEN
> +    if (d == dom0 && pte->pte & _PAGE_DEBUG_XEN) {
> +        old_pte = ptep_get_and_clear(mm, mpaddr, pte);
> +        return;
> +    }
> +#endif
> +
>      if (mfn == INVALID_MFN) {
>          // clear pte
>          old_pte = ptep_get_and_clear(mm, mpaddr, pte);

All the callers of domain_flush_and_put()(and domain_put_page())
needs similar hook for correctness.
(Or instead hook domain_flush_and_put() and domain_put_page())

Probably given that this functionality is for developpers, such a flaw
would be acceptable.

-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel