WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [PATCH] implement some PAL procedures

To: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] [PATCH] implement some PAL procedures
From: Tristan Gingold <tgingold@xxxxxxx>
Date: Sun, 4 Nov 2007 21:07:19 +0100
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sun, 04 Nov 2007 11:01:25 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20071031090912.GB28146%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <7kpryv67se.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20071031090912.GB28146%yamahata@xxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Wed, Oct 31, 2007 at 06:09:12PM +0900, Isaku Yamahata wrote:
> On Wed, Oct 31, 2007 at 04:51:45PM +0900, Kouya Shimura wrote:
> Content-Description: message body text
> 
> > +       case PAL_BRAND_INFO:
> > +           if (in1 == 0) {
> > +                   char brand_info[128];
> > +                   status = ia64_pal_get_brand_info(brand_info);
> > +                   if (status == PAL_STATUS_SUCCESS)
> > +                           copy_to_user((void *)in2, brand_info, 128);
> 
> copy_to_user()'s in the pal emulator seem to be leftovers
> from pre xencomm.
> Although it is right to integrate xencomm into GFW, I'm not sure
> it's worthwhile...

Good point.  I think it is worthwhile as a missing TC entry will crash the
domain (and maybe the hypervisor).
Adding xencomm for PAL (and SAL if necessary) requires coordinated work
between GFW and domU stubs.
IMHO this is a security hole if the hypervisor can be crashed.

Tristan.

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>