WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

[Xen-ia64-devel] Re: GFW - unsorted memmap?

To: Alex Williamson <alex.williamson@xxxxxx>
Subject: [Xen-ia64-devel] Re: GFW - unsorted memmap?
From: Tristan Gingold <tgingold@xxxxxxx>
Date: Tue, 9 Oct 2007 02:32:20 +0200
Cc: xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 08 Oct 2007 17:26:48 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1191604689.7247.8.camel@lappy>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1191553447.7491.166.camel@bling> <1191589548.470636ac9b008@xxxxxxxxxxx> <1191604689.7247.8.camel@lappy>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Fri, Oct 05, 2007 at 11:18:09AM -0600, Alex Williamson wrote:
> 
> On Fri, 2007-10-05 at 15:05 +0200, tgingold@xxxxxxx wrote:
> > Quoting Alex Williamson <alex.williamson@xxxxxx>:
> > 
> > > Hi Tristan,
> > >
> > >    I noticed that the memory map produced by the open source GFW isn't
> > > producing a sorted list.  It's putting the MMIO and I/O port space
> > > ranges after everything else.  This appears to be a bug in the EDK2 that
> > > it simply appends entries from the mGcdMemorySpaceMap list after those
> > > from the gMemoryMap list.  I did a quick and dirty bubble sort at the
> > > end of CoreGetMemoryMap() to fix this up.  Any ideas for a better
> > > solution?  Thanks,
> > 
> > I quickly browse EFI spec but I have not found the requirement.  Are you
> > sure the memmap must be sorted ?
> 
> Hi Tristan,
> 
>    I don't know if it's a spec requirement or simply convention, but in
> the past (and maybe still) Linux has made the assumption that the table
> is sorted.  I know all HP systems provide a sorted memory descriptor
> table.  IIRC, it was around the code that determines if all ranges
> within a memory granule have the same access attributes.  Thanks,

CoreGetMemoryMap seems to be the best place.  Feel free to send me the patch.
Nevertheless Linux should be fixed!

Tristan.

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>