WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [patch 08/16] kexec/kdump: Minor enhancement to inc

To: Alex Williamson <alex.williamson@xxxxxx>
Subject: Re: [Xen-ia64-devel] [patch 08/16] kexec/kdump: Minor enhancement to includes in crash.c
From: Horms <horms@xxxxxxxxxxxx>
Date: Tue, 25 Sep 2007 11:20:23 +0900
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 24 Sep 2007 19:21:00 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1189633146.6287.34.camel@lappy>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070912082834.175658477@xxxxxxxxxxxx> <20070912083045.294783692@xxxxxxxxxxxx> <1189633146.6287.34.camel@lappy>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: mutt-ng/devel-r804 (Debian)
On Wed, Sep 12, 2007 at 03:39:06PM -0600, Alex Williamson wrote:
> On Wed, 2007-09-12 at 17:28 +0900, Simon Horman wrote:
> > plain text document attachment (ia64-kexec-crash.c-includes.patch)
> > linux/uaccess.h was being included, but it seems that 
> > really the following includes are needed.
> > 
> > asm/page.h: for __va() and PAGE_SHIFT
> > asm/uaccess.h: for copy_to_user()
> > 
> > I guess that linux/uaccess.h pulls in both asm/page.h and asm/uaccess.h.
> > I notices this while backporting the code to xen's linux-2.6.16.33,
> > which does not have linux/uaccess.h. I'm posting it as I think it is a
> > correct, though somewhat cosmetic fix.
> 
> > Change isn't needed upstream
> > 
> > Index: x/arch/ia64/kernel/crash_dump.c
> > ===================================================================
> > --- x/arch/ia64/kernel/crash_dump.c 2007-04-17 11:44:02.000000000 +0900
> > +++ x/arch/ia64/kernel/crash_dump.c 2007-04-17 11:44:03.000000000 +0900
> > @@ -9,7 +9,8 @@
> >  #include <linux/errno.h>
> >  #include <linux/types.h>
> >  
> > -#include <linux/uaccess.h>
> > +#include <asm/page.h>
> > +#include <asm/uaccess.h>
> >  
> 
>    This should probably be wrapped in a #ifdef CONFIG_XEN for easier
> maintenance.  Thanks,

Thanks.

On the basis that this change isn't needed by upstream Linux
and that it doesn't fix a build or run time problem, although
I still think the change is techincally correct, I have
dropped it.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>