WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [PATCH 2/3] xencomm consolidation: linux side

To: SUZUKI Kazuhiro <kaz@xxxxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] [PATCH 2/3] xencomm consolidation: linux side
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Mon, 20 Aug 2007 12:52:02 +0900
Cc: Alex Williamson <alex.williamson@xxxxxx>, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sun, 19 Aug 2007 20:52:19 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070816032104.GA26953%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070816032104.GA26953%yamahata@xxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
Hi Kaz.

You may want to test the following hank.
Although I didn't change the logic, but it certainly needs fix.

NOTE:
[PATCH 0/12]MCA handler support for Xen/ia64 TAKE 2
http://lists.xensource.com/archives/html/xen-ia64-devel/2006-11/msg00358.html
http://lists.xensource.com/archives/html/xen-ia64-devel/2006-11/msg00362.html


On Thu, Aug 16, 2007 at 12:21:04PM +0900, Isaku Yamahata wrote:
> diff -r 3470a432a082 -r ea78d46a2ea0 include/asm-ia64/sal.h
> --- a/include/asm-ia64/sal.h  Tue Aug 07 16:54:04 2007 +0900
> +++ b/include/asm-ia64/sal.h  Thu Aug 16 11:55:08 2007 +0900
> @@ -701,9 +701,9 @@ ia64_sal_get_state_info (u64 sal_info_ty
>       if (is_running_on_xen()) {
>               struct xencomm_handle *desc;
>  
> -             if (xencomm_create(sal_info,
> -                                ia64_sal_get_state_info_size(sal_info_type),
> -                                &desc, GFP_KERNEL))
> +             desc = xencomm_map(sal_info,
> +                             ia64_sal_get_state_info_size(sal_info_type));
> +             if (desc == NULL)
>                       return 0;
>  
>               SAL_CALL_REENTRANT(isrv, SAL_GET_STATE_INFO, sal_info_type, 0,

-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel