WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

[Xen-ia64-devel] [PATCH] [CONSOLE] vga_con doesn't exist without CONFIG_

To: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-ia64-devel] [PATCH] [CONSOLE] vga_con doesn't exist without CONFIG_VGA_CONSOLE
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Thu, 09 Aug 2007 11:05:22 +0900
Cc: Alex Williamson <alex.williamson@xxxxxx>
Delivery-date: Wed, 08 Aug 2007 19:05:37 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
I'm not sure when this regression came in, but with my kernel setup I get
the following error on compile.  It seems farily trivial to fix by
rearanging the logic a little and guarding access to vga_con with #ifdef
CONFIG_VGA_CONSOLE

arch/ia64/kernel/built-in.o: In function
`setup_arch':arch/ia64/kernel/setup.c:616: undefined reference to `vga_con'
:arch/ia64/kernel/setup.c:616: undefined reference to `vga_con'

Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>

Index: linux-2.6.18-xen.hg/arch/ia64/kernel/setup.c
===================================================================
--- linux-2.6.18-xen.hg.orig/arch/ia64/kernel/setup.c   2007-08-09 
09:44:52.000000000 +0900
+++ linux-2.6.18-xen.hg/arch/ia64/kernel/setup.c        2007-08-09 
09:50:58.000000000 +0900
@@ -613,10 +613,12 @@ setup_arch (char **cmdline_p)
                        int offset = 0;
 
                        memset(name, 0, sizeof(name));
-                       if (is_initial_xendomain() && conswitchp != &vga_con)
-                               strncpy(name, "ttyS", 4);
-                       else
+#if defined(CONFIG_VGA_CONSOLE)
+                       if (!is_initial_xendomain() || conswitchp == &vga_con)
                                strncpy(name, "tty", 3);
+                       else
+#endif
+                               strncpy(name, "ttyS", 4);
 
                        p = strstr(*cmdline_p, "xencons=");
 

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>