Re: [Xen-ia64-devel] regarding dom_fw_setup

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

Good catch.
It's fixed in the tip of xen-ia64-devel.hg. (15154:b46c2ff6dfb0)
Is there any other suspicious code?

On Sun, Jun 03, 2007 at 05:02:51PM +0530, jeet wrote:
> Hi All
> 
> I am looking into code of construct_dom0()
> 
> which call dom_fw_setup() to setup the firmware related mapping in 
> domain identity mapped virtual address space
> 
> But in dom_fw_setup() it there is a code as below
> 
> <snippet start>
>   /* Create page for acpi tables.  */
>        if (d != dom0) {
>             void *imva;
>  
>              assign_new_domain_page_if_dom0(d, FW_ACPI_BASE_PADDR);
>                  imva = doamin_mps_to_imva (d, FW_ACPI_BASE_PADDR);
>                 dom_fw_fake_acpi(d, (struct fake_acpi_tables *)imva);
>         }
> <snippet end>
> 
> here if it is not dom0 then it call 
> assign_new_domain_page_if_dom0
> 
> but inside this it checking if dom=dom0 then it assign page otherwise return
> So what is purpose of this code here?
> 
> or the check should be if (d == dom0) ?
> 
> jeet
> 
> 
> 
> 
>       Looking for people who are YOUR TYPE? Find them at in.groups.yahoo.com
> 
> _______________________________________________
> Xen-ia64-devel mailing list
> Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-ia64-devel
> 

-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel