WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [PATCH] make p2m exposure compatible with suspend/r

To: Tristan Gingold <tgingold@xxxxxxx>
Subject: Re: [Xen-ia64-devel] [PATCH] make p2m exposure compatible with suspend/resume
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Wed, 9 May 2007 12:02:44 +0900
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 08 May 2007 20:00:58 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070508133222.GA16093@saphi>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070507055857.GE6474%yamahata@xxxxxxxxxxxxx> <20070507060350.GG6474%yamahata@xxxxxxxxxxxxx> <20070508064119.GB17995%yamahata@xxxxxxxxxxxxx> <20070508133222.GA16093@saphi>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Tue, May 08, 2007 at 03:32:22PM +0200, Tristan Gingold wrote:

> you should really define the TR used by the p2m in kregs.h.  Using a define
> is less error-prone than a hard coded number (0x2).
> 
> (I don't object against this specific patch as the hard-coded number use is
>  already commited in the tree).

0x2 means DTR (and 0x1 means ITR). not index to TR.
I agree that ia64_ptr(), ia64_itr() and ia64_itc() should use
symbolical definition.
-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel