WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [PATCH][RFC] enable CONFIG_IA64_GENERIC and paravir

To: Alex Williamson <alex.williamson@xxxxxx>
Subject: Re: [Xen-ia64-devel] [PATCH][RFC] enable CONFIG_IA64_GENERIC and paravirtualize swiotlb & sba_iommu
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Thu, 3 May 2007 22:23:02 +0900
Cc: xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 03 May 2007 06:21:41 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1178170051.28577.84.camel@bling>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1178170051.28577.84.camel@bling>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Wed, May 02, 2007 at 11:27:31PM -0600, Alex Williamson wrote:
> --- linux-2.6-xen-sparse/arch/ia64/hp/common/sba_iommu.c      2006-09-19 
> 21:42:06.000000000 -0600
> +++ linux-2.6-xen-sparse/arch/ia64/hp/common/sba_iommu.c      2007-05-02 
> 22:52:34.000000000 -0600
> @@ -944,7 +943,7 @@
>  
>       while (size > 0) {
>               ASSERT(((u8 *)pdir_start)[7] == 0); /* verify availability */
> -             sba_io_pdir_entry(pdir_start, (unsigned long) addr);
> +             sba_io_pdir_entry(pdir_start, virt_to_bus(addr));
>  
>               DBG_RUN("     pdir 0x%p %lx\n", pdir_start, *pdir_start);
>  

sba_io_pdir_entry() seems to expect virtual address as 2nd argument
so that modifying sba_io_pdir_entry() itself would be better than
modifying all callers argument.
I don't know the sba_iommu spec, though.
-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>