xen-ia64-devel

[Top] [All Lists]

[Xen-ia64-devel] Re: [Xen-devel] [PATCH][RFC] Support GPT (GUID Partitio

from [KUWAMURA Shin'ya]

[Permanent Link][Original]

To:	keir@xxxxxxxxxxxxx
Subject:	[Xen-ia64-devel] Re: [Xen-devel] [PATCH][RFC] Support GPT (GUID Partition Table)
From:	"KUWAMURA Shin'ya" <kuwa@xxxxxxxxxxxxxx>
Date:	Thu, 12 Apr 2007 17:28:18 +0900 (JST)
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Thu, 12 Apr 2007 01:28:11 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<C242AEF9.D256%keir@xxxxxxxxxxxxx>
List-help:	<mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id:	Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post:	<mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<014101c77c0d$de1055a0$ecb1220a@fj98229700> <C242AEF9.D256%keir@xxxxxxxxxxxxx>
Sender:	xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx

Hi Keir,

>>>>> On Wed, 11 Apr 2007 15:27:53 +0100
>>>>> keir@xxxxxxxxxxxxx(Keir Fraser)  said:
> 
> On 11/4/07 08:48, "Takahashi Tomohiro" <takatom@xxxxxxxxxxxxxx> wrote:
> 
> > I made a patch for GPT support.
> 
> I don't see anything wrong with it, although won't it always be the first
> legacy partition that is marked with type 0xee?

No, but this patch supports the second (or third, ...) legacy
partition marked with 0xee.
# I have no idea whether it is necessary well...

This patch has different problems. get_active_partition() returns a
entry of a legacy partition. Since the structure of GPT partition
entries differs from the structure of legacy partition entries, this
patch has the following problem:

 - pygrub cannot access a domain more than 2^32 * SECTOR_SIZE because
   get_fs_offset() treats the offset as a 32-bit integer. In GPT, the
   offset must be treated as 64-bit integer.

 - This patch returns a part of a GUID unique to the partition as
   legacy partition types. pygrub may misunderstand partition types.

I plan to fix this problem.

Best Regards,
-- 
  KUWAMURA Shin'ya

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH][RFC] Support GPT (GUID Partition Table), Takahashi Tomohiro Re: [Xen-devel] [PATCH][RFC] Support GPT (GUID Partition Table), Keir Fraser [Xen-ia64-devel] Re: [Xen-devel] [PATCH][RFC] Support GPT (GUID Partition Table), KUWAMURA Shin'ya <= [Xen-ia64-devel] Re: [Xen-devel] [PATCH][RFC] Support GPT (GUID Partition Table), KUWAMURA Shin'ya

Previous by Date:	Re: [Xen-ia64-devel] [PATCH] PV-on-HVM fix, Doi . Tsunehisa
Next by Date:	[Xen-ia64-devel] [PATCH] fix hyper_get_psr, Isaku Yamahata
Previous by Thread:	Re: [Xen-devel] [PATCH][RFC] Support GPT (GUID Partition Table), Keir Fraser
Next by Thread:	[Xen-ia64-devel] Re: [Xen-devel] [PATCH][RFC] Support GPT (GUID Partition Table), KUWAMURA Shin'ya
Indexes:	[Date] [Thread] [Top] [All Lists]