WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [PATCH][RFC] fix ia64 grant_table destruction

To: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] [PATCH][RFC] fix ia64 grant_table destruction
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Wed, 14 Mar 2007 15:52:04 -0600
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 14 Mar 2007 14:51:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070314120415.GF13931%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: OSLO R&D
References: <20070314120415.GF13931%yamahata@xxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2007-03-14 at 21:04 +0900, Isaku Yamahata wrote:
> [PATCH][RFC]
> fix ia64 grant_table destruction.
> fix type count of grant mapped page for xen/ia64.
> 
> 
> This patch is necessary to keep page_info.type_info
> correctly. However I don't think that this patch is acceptable.
> Another idea is to modify guest_physmap_remove_page() be aware
> of grant table mapped page.

Hi Isaku,

   I agree, this doesn't feel like the best solution.  It's interesting
that the comment on cset 8409 (that commented out the line this patch
adds back) adds gnttab_release_mappings() after
domain_relinquish_resources().  Makes me wonder if the implicit put_page
comment is still entirely valid for x86.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>