Re: [Xen-devel] [PATCH 0/2] dump-core take 3

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Mon, 2007-01-22 at 01:23 +0900, Isaku Yamahata wrote:
> On Sun, Jan 21, 2007 at 03:28:37PM +0000, Keir Fraser wrote:

> > Seems to me you have your own brand new numbering space if
> > you pick a new name.
> 
> Yes in thery.
> Unfortunately binutils and elfutils don't see name.
> They simply check number and report type.

We've been treating the "Xen" namespace as our own and already have some
notes which overlap other notes in other namespaces. If binutils or
other tools have a problem with this then they should be fixed. Since
this is just an issue when using readelf etc to display the notes I
don't think it is critical enough to work around like this. Tools which
actually manipulate the notes seem to do the right thing.

I think the definitions should be in xen/include/public/elfnote.h rather
than starting a second list in tools/libxc/xc_core.h.

I also think these notes should use the "Xen" namespace which is already
used for the boot notes (0x0.......) and kexec support (0x1.......)
rather than the "XEN CORE" namespace, possibly using 0x2........

There's a possibility that you might be able to extend
XEN_ELFNOTE_CRASH_REGS/crash_xen_core_t to meet your needs rather than
adding NT_XEN_PRSTATUS/xen_note_prstatus.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel